Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipFiles not working #1226

Open
PrasannaVenkadesh opened this issue Jun 8, 2024 · 1 comment · May be fixed by #1254
Open

skipFiles not working #1226

PrasannaVenkadesh opened this issue Jun 8, 2024 · 1 comment · May be fixed by #1254

Comments

@PrasannaVenkadesh
Copy link

skipFiles has no effect with installExt or installDirs.

Sample package structure,

folder
|- app.nimble
|- src
    |- app.nim
    |- appPkg
        |- utils.nim
        |- protocol.nim

Corresponding nimble file

srcDir        = "src"
installExt    = @["nim"]
skipFiles     = @["appPkg/utils.nim"]

Expected Behaviour

All files inside appPkg should be copied except appPkg/utils.nim

Actual Behaviour

appPkg is copied as it is.

@xTrayambak
Copy link
Contributor

It seems like samePaths incorrectly returns false when provided with the absolute path of the file during checkInstallFile checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants