Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out a way to convert Continuation to Env only once per continuation #184

Open
alaviss opened this issue Jun 24, 2021 · 1 comment · May be fixed by #195
Open

Figure out a way to convert Continuation to Env only once per continuation #184

alaviss opened this issue Jun 24, 2021 · 1 comment · May be fixed by #195
Labels
enhancement New feature or request

Comments

@alaviss
Copy link
Contributor

alaviss commented Jun 24, 2021

Converting to Env is extremely expensive due to how Nim's object conversion check is implemented.

Currently we perform one conversion per environment access, which gets pretty expensive (try compiling stash/performance with --objChecks:on).
@alaviss alaviss added the enhancement New feature or request label Jun 24, 2021
@disruptek
Copy link
Contributor

I think Nim has plenty of knobs and levers here and I don't really want to turn the checks off at all -- it just seems unnecessary and out of scope.

That said, we could just push object checks on during the initial whelping and then push them off around the continuation legs.

@alaviss alaviss linked a pull request Jun 28, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a pass to optimize environment conversion alaviss/cps
2 participants
@disruptek @alaviss