Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++ 17 #12

Closed
ringabout opened this issue Oct 28, 2021 · 5 comments
Closed

Use C++ 17 #12

ringabout opened this issue Oct 28, 2021 · 5 comments

Comments

@ringabout
Copy link
Contributor

ringabout commented Oct 28, 2021

Merge nim-lang/Nim#17375

Initialization of parent struct in C++ appeared only in C++17.

It solves many issues. As a bonus the compiler itself can be bootstrapped by --gc:orc -b:cpp.
fix nim-lang/Nim#18410
fix nim-lang/Nim#17351
A workaround can be removed: nim-lang/Nim#18836 (comment)

@alaviss
Copy link
Contributor

alaviss commented Oct 28, 2021

C++ backend is on the flaky side. We don't even know what are its expectations and what is the generator design.

I'd say changes to it will be on very low priority.

@disruptek
Copy link
Contributor

I see two issues enumerated and it's impossible to know how many issues will be introduced. I think we have to ignore the backends until they are the weak link; garbage in, garbage out, right.

Though I admit that I do wish the cpp backend worked more often, and I'm curious if this could help CPS's C++ codegen issues. 😬

@saem
Copy link
Collaborator

saem commented Oct 29, 2021

I see two issues enumerated and it's impossible to know how many issues will be introduced. I think we have to ignore the backends until they are the weak link; garbage in, garbage out, right.

I totally agree that this is very low priority and I've got no interest in supporting knock on effects. Guess that means that the near term mission needs further clarification.

@saem
Copy link
Collaborator

saem commented Oct 29, 2021

@xflywind can you reread the readme to see what's the mission right now and based on your understanding do one of the following:

  • start a discussion asking to expand the scope and how you'll support that expansion
  • open an issue, asking to clarify the near term mission, along with your current interpretation

I'd like to avoid doing this issue by issue stuff, as that's painful for everyone, and at the same time want to make sure you're heard and vice versa.

@ringabout
Copy link
Contributor Author

Fair enough. The alternative way is nim-lang/Nim#18836 to workaround one of the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants