Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python path broken under Linux #10

Closed
notfood opened this issue Aug 26, 2023 · 6 comments
Closed

Python path broken under Linux #10

notfood opened this issue Aug 26, 2023 · 6 comments
Labels
solved Problem solved

Comments

@notfood
Copy link

notfood commented Aug 26, 2023

This line fails on Linux due to the path:

term.sendText(`${pathComfy}\\python_embeded\\python.exe -s ${pathComfy}/ComfyUI/main.py --enable-cors-header --preview-method auto ${args}`);

My ComfyUI install doesn't have a python_embeded folder. Ideally it should be using the venv's python. If this could be specified by setting variable, it'd work for both Linux and Windows.

@nimadez
Copy link
Owner

nimadez commented Aug 26, 2023

MD updated to support user-defined Python path, please update, thank you.

@notfood
Copy link
Author

notfood commented Aug 26, 2023

There appears to be an error on the update.

term.sendText(`${pathPython} -s ${pathComfy}/ComfyUI/main.py --enable-cors-header --preview-method auto ${args}`);

It has an additional ComfyUI in the path, causing it to execute instead: . . ./ComfyUI/ComfyUI/main.py

Note the double ComfyUI

@nimadez
Copy link
Owner

nimadez commented Aug 26, 2023

MD updated, user must specify ComfyUI source-code directory instead of root directory, please let me know if the problem is solved.

@notfood
Copy link
Author

notfood commented Aug 26, 2023

There must be a race condition or something. When I run ComfyUI standalone, Checkpoint and VAE combo boxes are populated correctly, when I allow the extension to start ComfyUI (it starts correctly), it doesn't populate them, no matter what I do.

ComfyUI folder: /media/Makai/home/Projects/AI/ComfyUI

With Python path: source /media/Makai/home/Projects/AI/ComfyUI/venv/bin/activate && python
Models won't load:
image

With Python path: /bin/false and pre-starting ComfyUI
Models load:
image

The issue has been fixed, but a different one arose.

@nimadez
Copy link
Owner

nimadez commented Aug 26, 2023

Checkpoints are received from the ComfyUI server, this problem has nothing to do with paths. I am looking for the cause of the problem to find a solution, but unfortunately I have not yet been able to reproduce the new issue.

@notfood
Copy link
Author

notfood commented Aug 26, 2023

Yeah, seems strange to me, the start commands look the same, ComfyUI starts correctly, binds to the port just fine, but it won't populate the combo boxes. Pressing Generate will send the command to ComfyUI but it'll complain that there is no model in the inputs while the MD UI waits forever. I'll be pre-starting ComfyUI in the meantime.

@notfood notfood closed this as completed Aug 26, 2023
@nimadez nimadez added the solved Problem solved label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved Problem solved
Projects
None yet
Development

No branches or pull requests

2 participants