Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Election demo web build started breaking due to dependency change #47

Closed
joshuaauerbachwatson opened this issue Jan 29, 2021 · 4 comments
Assignees

Comments

@joshuaauerbachwatson
Copy link
Contributor

The election demo has a lot of open dependencies. It recently entered a state where the actual dependencies that are loaded are inconsistent:

> election@1.0.0 build .../main/config/deployable/election/web
> react-scripts build

Creating an optimized production build...
Failed to compile.

./node_modules/mobx-react-lite/es/utils/assertEnvironment.js
Attempted import error: 'makeObservable' is not exported from 'mobx'.

This breaks the Jenkins deploy job. I am separately recommending that we take the election demo out of the main build until this is fixed.

@joshuaauerbachwatson
Copy link
Contributor Author

The election demo is (temporarily, at least) removed from dev builds to keep the Jenkins pipeline running.

If the demo is fixed, the change in main is easily reversed. If, for some reason we can't (or decide not to) fix the demo build, then it should probably be retired completely because I believe customers would have problems building it as well.

@joshuaauerbachwatson
Copy link
Contributor Author

The PR to fix this has been verified and merged. We can wait to close the issue until after we verify the build again as part of the main Nimbella build.

@rabbah
Copy link
Contributor

rabbah commented Jan 31, 2021

I suggest setting up GitHub actions to build the demos.

@bhageena
Copy link
Contributor

bhageena commented Feb 3, 2021

The issue has been resolved, and the actionable item herein has been moved out as an independent issue.

@bhageena bhageena closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants