Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#493] Integrate danger to the generated project #579

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thawzintoe-ptut
Copy link

@thawzintoe-ptut thawzintoe-ptut commented Jun 5, 2024

#493

What happened 馃憖

CI/CD pipeline specifically for reviewing pull requests within our Android project template. A total of 76 additions have been made to the .github/workflows/repiew_pull_request.yml file, enhancing its capabilities and adding new steps for better code quality checks and environment management.

Insight 馃摑

  • Detekt and Android Lint: Ensure code quality and styling compliance.
  • Kover for Unit Tests: Enforce test coverage metrics.
  • Danger: Manage PR annotations for common issues like big PRs or missing descriptions.

Proof Of Work 馃摴

Screenshot 2567-06-05 at 22 07 10

Copy link

github-actions bot commented Jun 5, 2024

1 Warning
鈿狅笍 Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

馃 Template - Compose Unit Tests Code Coverage: 61.54%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Dangerfile
Gemfile
Gemfile.lock
review_pull_request.yml
template_review_pull_request.yml

Codebase cunningly covered by count Shroud 馃

Generated by 馃毇 Danger

@thawzintoe-ptut thawzintoe-ptut force-pushed the feature/493-integrate-danger-to-the-generated-project branch from 8c6984f to db8238c Compare June 26, 2024 11:03
[#498] Added JDK setup in github action

[#493] Update code according to PR comment for template_review_pull_request.yml
@thawzintoe-ptut thawzintoe-ptut force-pushed the feature/493-integrate-danger-to-the-generated-project branch from db8238c to 003bb3b Compare June 26, 2024 11:05
@thawzintoe-ptut thawzintoe-ptut deployed to template-compose June 26, 2024 11:06 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Danger to the generated project
2 participants