Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicated Dockerfile and .dockerignore when generating the project with Rails 7.1 #478

Closed
sanG-github opened this issue Nov 9, 2023 · 2 comments · Fixed by #481
Closed
Assignees

Comments

@sanG-github
Copy link
Contributor

sanG-github commented Nov 9, 2023

Issue

We're facing two duplicating errors when generating the project from our template that should be fixed ASAP👷‍

image

Expected

The template can generate a project successfully and there are no duplications or errors caused to the user

Steps to reproduce

Both ways to generate the project faced the same issue.

1. Run `rails new app_name -m https://raw.githubusercontent.com/nimblehq/rails-templates/main/template.rb` as documented.

Or

1. Clone our rails template locally
2. Run `rails new app_name -m ./template.rb`
@malparty
Copy link
Member

malparty commented Nov 10, 2023

Note that this only occurs since Rails 7.1, as Rails introduced a default Dockerfile in the base template 😇

@malparty malparty self-assigned this Nov 10, 2023
@malparty
Copy link
Member

Can be fixed with simple

remove_file 'Dockerfile'
remove_file '.dockerignore'

Later we might want to reuse these default dockerfiles but that's in research for the current sprint 👍

@malparty malparty changed the title Fix: Duplicating Dockerfile and .dockerignore when generating the project Fix: Duplicated Dockerfile and .dockerignore when generating the project with Rails 7.1 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants