Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package dependencies don't require corresponding versions when built together #19

Closed
uglybugger opened this issue Dec 15, 2013 · 4 comments
Assignees
Labels

Comments

@uglybugger
Copy link
Contributor

Nimbus.MessageContracts depends on Nimbus. Both are built as part of the same solution and packed via nuget.exe as part of the same build pass.

Looks like the call to nuget.exe pack doesn't set package version dependencies, so Nimbus itself only has a dependency on Nimbus.MessageContracts v0.0.1 no matter what version the Nimbus package is.

@uglybugger
Copy link
Contributor Author

Not marking this as "up for grabs" as it's likely to require access to the TC server to resolve.

@ghost ghost assigned DamianMac Dec 16, 2013
@uglybugger
Copy link
Contributor Author

This might have been an issue with our not having configured TC's AssemblyInfo patcher. Just turned that build feature on (TC 7 is so old-school ;) ) so we'll see.

@DamianMac
Copy link
Contributor

I can upgrade it to 8, next week.

On Sat, Dec 21, 2013 at 8:52 PM, uglybugger notifications@github.comwrote:

This might have been an issue with our not having configured TC's
AssemblyInfo patcher. Just turned that build feature on (TC 7 is so
old-school ;) ) so we'll see.


Reply to this email directly or view it on GitHubhttps://github.com/DamianMac/Nimbus/issues/19#issuecomment-31060973
.

@uglybugger
Copy link
Contributor Author

All good. Issue was we had a hard-coded version number in the .nuspec files that wasn't being replaced. I've replaced that with the $version$ token and turned on the AssemblyInfo patcher. Package dependencies have the correct versions now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants