Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional diagnostic properties on dispatch failure #45

Closed
michaelnoonan opened this issue Feb 13, 2014 · 4 comments
Closed

Additional diagnostic properties on dispatch failure #45

michaelnoonan opened this issue Feb 13, 2014 · 4 comments

Comments

@michaelnoonan
Copy link
Contributor

When a dispatch failure occurs the Exception Type, Message and StackTrace are recorded as message properties. Add timestamp, failed path, executing identity and machine name to help diagnose dispatch failures.

@uglybugger
Copy link
Contributor

This would be really useful and a fairly simple intro to the project for anyone interested.

@michaelnoonan
Copy link
Contributor Author

I've added timestamp, executing identity and machine name (in 43c30b9) but the failed path will be a bit more tricksy.

Should we take the "To" field as gospel, or the IMessageReceiver._path as gospel (and promote it to a property)?

@michaelnoonan michaelnoonan self-assigned this Feb 13, 2014
@uglybugger
Copy link
Contributor

Hmm.. I'm thinking the "To" field unless we can think of a good reason not to. Do you see this affecting what happens when we consolidate dead letters into a single queue?

@uglybugger uglybugger added this to the Future milestone Feb 22, 2014
@michaelnoonan
Copy link
Contributor Author

I think it's a good idea. I copied To and ReplyTo into those Diagnostics
Headers when centralising dead letters, but ran into some situations where
To and ReplyTo were null, but didn't get to the bottom of why.

For centralising dead letters I used a Property called "FailedPath" or
similar so the infrastructure knows where to send the message for Replay.

On Sat, Feb 22, 2014 at 11:09 AM, uglybugger notifications@github.comwrote:

Hmm.. I'm thinking the "To" field unless we can think of a good reason not
to. Do you see this affecting what happens when we consolidate dead letters
into a single queue?

Reply to this email directly or view it on GitHubhttps://github.com/DamianMac/Nimbus/issues/45#issuecomment-35789807
.

@michaelnoonan michaelnoonan removed their assignment Mar 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants