Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter selection of addresses in add-address that ensures discoverability #400

Open
danimoh opened this issue Mar 5, 2020 · 0 comments

Comments

@danimoh
Copy link
Member

danimoh commented Mar 5, 2020

Currently, when a user adds new addresses that span more than the ACCOUNT_MAX_ALLOWED_ADDRESS_GAP (see WalletInfoCollector) without using them, following addresses will not be detected on login even if they were used. Although obviously no funds are lost, this is confusing to the user and not user friendly.

To avoid this issue, we should only offer addresses at most 20 apart from the last created address that was actually used instead of addresses within a gap of 20 from the last created address.
A drawback of this is that the order of displayed addresses will not necessarily be the creation order anymore if the user creates a higher index first without using it then creating an additional address with lower index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant