Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] more feedback #20

Closed
3 of 5 tasks
timotheecour opened this issue Nov 28, 2018 · 1 comment
Closed
3 of 5 tasks

[TODO] more feedback #20

timotheecour opened this issue Nov 28, 2018 · 1 comment

Comments

@timotheecour
Copy link
Contributor

timotheecour commented Nov 28, 2018

  • is that a bug?
    if gStateRT.mode.len != 0: gStateRT.mode = “cpp"

  • globals.nim:
    State* = object
    => State* = ref object

  • this change:
    node.children.len
    =>
    tsNodeNamedChildCount()
    seems works; can we add back a nicer API (where one can use len) ?

  • README needs to be updated to reflect Move AST to Nim processing into toast commit

  • s/staticExec/gorgeEx/g (staticExec less safe, ignores exit code)

@genotrance
Copy link
Collaborator

For 3, would be cool to add an idiomatic Nim layer on top of tree-sitter that we can simply use.

For 5, there's execAction() in git.nim which can be leveraged.

@timotheecour timotheecour changed the title more feedback [TODO] more feedback Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants