REST: should process_post flow include content_types_accepted?

[jbothma]

I think process_post should happen after the appropriate content_types_accepted callback has been called. In 0.6.1 it seems that content_types_accepted is ignored when post_is_create returns false and it doesn't seem like this changed up to master.

The point of this change is that even when I'm doing a "process sort of" POST, I still want to do different decoding given application/json or application/x-www-form-urlencoded. I can either do my processing in my provided callback or set the data in my state and do the processing in process_post as per the current API.

Am I missing something or does this sound sensible enough for a pull request?

[jbothma]

This change might have to break stuff for rest handlers that conditionally return true from post_is_create and don't expect their content_types_accepted callbacks to be called when they returned false.

[essen]

Yeah that's planned.

[teburd]

I have a PR/patch for this if your interested check it out.

[jbothma]

@BFrog Are you referring to #296 ? I've already cherry-picked that for the moment as a workaround :). I think it's similar but not quite the same. Or is there another patch somewhere for this issue?

[essen]

Hey @BFrog I was hoping I could see with you for these PRs at some point. I'm sick right now so not exactly in the mood for it but perhaps next week?

[teburd]

Sure that sounds good

[ivlis]

#296 would be a great improvement! Have to fork and cherry pick it. Can't wait to see it in vanilla cowboy.

[essen]

@BFrog I need a few changes to the existing PRs, and if you already have done POST can you open a PR for it too? Thanks.

[essen]

Patches welcome.

[essen]

Done in 5a171d0. Please open new tickets if there's issues. Thanks!