Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETS setting? #80

Closed
cnDenis opened this issue Jun 6, 2014 · 5 comments
Closed

ETS setting? #80

cnDenis opened this issue Jun 6, 2014 · 5 comments

Comments

@cnDenis
Copy link

cnDenis commented Jun 6, 2014

In source code, the ets table is created by this parameters

ranch_server = ets:new(ranch_server, [ordered_set, public, named_table]),

Why use ordered_set instead of set ? Why write_concurrency not enabled as it said in https://github.com/extend/ranch/blob/master/guide/internals.md?

@nevar
Copy link
Contributor

nevar commented Jun 6, 2014

See 33db3b0 about write_concurrency.

@cnDenis cnDenis closed this as completed Jun 6, 2014
@essen
Copy link
Member

essen commented Jun 6, 2014

Whoops the guide needs fixing.

@cnDenis
Copy link
Author

cnDenis commented Jun 6, 2014

write_concurrency is no effect on odered_set, why not use set?
http://www.erlang.org/doc/man/ets.html#new-2

{write_concurrency,boolean()} Performance tuning. ...
In current implementation, table type ordered_set is not affected by this option. Also, ...

@cnDenis cnDenis reopened this Jun 6, 2014
@essen
Copy link
Member

essen commented Jun 6, 2014

There's no need for concurrency anymore, and yep someone pointed that out a while ago also but it doesn't matter now.

@essen
Copy link
Member

essen commented Jun 6, 2014

Fixed the guide in 6e2645d. Thanks!

@essen essen closed this as completed Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants