Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Issues with XWS file #64

Closed
stickus opened this issue Dec 19, 2017 · 3 comments
Closed

Issues with XWS file #64

stickus opened this issue Dec 19, 2017 · 3 comments
Labels
Milestone

Comments

@stickus
Copy link

stickus commented Dec 19, 2017

Haven't found many XWS files that won't load, but this is one of them. No error message, just refused to load it.

{"description":"","faction":"rebel","name":"Ray's Fair Ship","pilots":[{"name":"lowhhrick","points":29,"ship":"auzituckgunship","upgrades":{"ept":["selflessness"],"crew":["chopper"]}},{"name":"roarkgarnet","points":29,"ship":"hwk290","upgrades":{"turret":["twinlaserturret"],"crew":["niennunb"],"title":["moldycrow"]}},{"name":"biggsdarklighter","points":28,"ship":"xwing","upgrades":{"amd":["r2d6"],"ept":["swarmtactics"],"mod":["integratedastromech"]}},{"name":"captainrex","points":14,"ship":"tiefighter"}],"points":100,"vendor":{"yasb":{"builder":"(Yet Another) X-Wing Miniatures Squad Builder","builder_url":"https://geordanr.github.io/xwing/","link":"https://geordanr.github.io/xwing/?f=Rebel%20Alliance&d=v4!s!251:235,-1,167:-1:-1:;46:135,32:3:-1:;4:-1,70:-1:20:U.9;224::-1:-1:&sn=Ray's%20Fair%20Ship&obs="}},"version":"0.3.0"}

@kingargyle
Copy link
Collaborator

Thanks, there is a pilot that doesn't have any upgrades. And this is causing a NullPointer Exception to be thrown. I've got a fix for this, and will release 0.7.2 tonight with the fix.

@kingargyle kingargyle reopened this Dec 19, 2017
kingargyle added a commit that referenced this issue Dec 19, 2017
When a ship has no upgrades the XWS file won't load because
there is a NPE error when looking to check Veteran Instincs
calculations.
@kingargyle kingargyle added the bug label Dec 19, 2017
@kingargyle kingargyle added this to the 0.7.2 milestone Dec 19, 2017
@kingargyle
Copy link
Collaborator

Pushed the fix for this and will do a release tonight when I get home.

@kingargyle
Copy link
Collaborator

@stickus v0.7.2 is now available with the fix. https://github.com/NineWorlds/xstreamer/releases/tag/v0.7.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants