Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build outputs modified after the build outside of ninja are not rebuilt #1946

Open
Dragnalith opened this issue Mar 30, 2021 · 0 comments
Open

Build outputs modified after the build outside of ninja are not rebuilt #1946

Dragnalith opened this issue Mar 30, 2021 · 0 comments

Comments

@Dragnalith
Copy link

Dragnalith commented Mar 30, 2021 •
edited

In the case you manually modified a build output, the output will not be rebuilt to its correct state because ninja does not consider it dirty. I think the behavior should be considered as bug, because having a build node is in a state different from the one it would have if the rule command of its edge was executed again is the definition of being dirty.

I have a simple fix the following PR #1951.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dragnalith