Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line option similar to GNU make --question #905

Open
sgraham opened this issue Jan 23, 2015 · 9 comments
Open

Add command line option similar to GNU make --question #905

sgraham opened this issue Jan 23, 2015 · 9 comments
Labels

Comments

@sgraham
Copy link
Contributor

sgraham commented Jan 23, 2015

(I feel like we had this discussion before, but I can't find it now)

http://www.gnu.org/software/make/manual/make.html#Running

-q seems like the wrong name, as it could be "quiet" as well. But to confirm no-op builds in Chromium, that project would like to have ninja emit a status code when the build is dirty.

@sgraham
Copy link
Contributor Author

sgraham commented Jan 23, 2015

@dpranke
Copy link

dpranke commented Jan 23, 2015

+1. I also think this would be a nice switch to have.

@dpranke
Copy link

dpranke commented Jan 23, 2015

You could also add a '-t up-to-date' or something to avoid having to add a new top-level argument.

@sgraham
Copy link
Contributor Author

sgraham commented Jan 23, 2015

(I actually think log parsing is just fine, but opened this per bikeshedding over there.)

@nico
Copy link
Collaborator

nico commented Jan 23, 2015

I too think log parsing is fine, the "no work to do" change isn't ever going to change anyway.

But this seems like a reasonable feature request anyhow.

@riannucci
Copy link
Contributor

Bikeshedder jumping in to defend himself: a well-intentioned addition of internationalization to ninja would break your assumptions 😛

@riannucci
Copy link
Contributor

Alternately: as long as you promise that I won't be on the hook for maintaining the log parsing ever, then I'm fine with it ^_^

@sgraham
Copy link
Contributor Author

sgraham commented Jan 28, 2015

It's true. (We also have to emit "ninja: Entering directory `out\Release'" to match something in Emacs. English or bust!)

@evmar
Copy link
Collaborator

evmar commented Jan 29, 2015

I feel bad about the Emacs thing but it's soooo convenient.

BTW this is what Emacs has to say about the default value of the pattern:

compilation-directory-matcher's value is ("\\(?:Entering\\|Leavin\\(g\\)\\) directory `\\(.+\\)'$"
 (2 . 1))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants