Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version check screen to TitleState #155

Merged
merged 1 commit into from Jan 15, 2021
Merged

Move version check screen to TitleState #155

merged 1 commit into from Jan 15, 2021

Conversation

gedehari
Copy link
Contributor

@gedehari gedehari commented Jan 5, 2021

Moving the version check screen to TitleState, allows the game to make early decisions whether to switch to MainMenuState or OutdatedSubState.
Also solves the weird trantition bug.

Before:

version-check-fix--before.mp4

After:

version-check-fix--after.mp4

Let me know if there needs to be a change before merging. Thanks.

@ninjamuffin99
Copy link
Member

aw yeahhh aight shawty

@ninjamuffin99 ninjamuffin99 merged commit 88a8918 into FunkinCrew:master Jan 15, 2021
@gedehari gedehari deleted the version-check-fix branch January 17, 2021 11:55
kudorado pushed a commit to kudorado/Funkin that referenced this pull request Jul 18, 2021
Move version check screen to TitleState
ninjamuffin99 added a commit that referenced this pull request Mar 9, 2023
Move version check screen to TitleState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants