Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music issues throughout the game #48

Merged
merged 5 commits into from
Dec 13, 2020
Merged

Music issues throughout the game #48

merged 5 commits into from
Dec 13, 2020

Conversation

sqirradotdev
Copy link
Contributor

@sqirradotdev sqirradotdev commented Dec 10, 2020 •
edited
Loading

Some bugs related to music.

  • Going to Freeplay menu then exit immediately causes the music volume to stop going up
  • Returning to Main Menu (from exiting/finishing the gane) doesnt play main menu music
  • Pausing the game right when the song started doesn't pause the song, but it continues playing until unpausing and pausing again.
  • Pausing early in the game (during the 3 beat countdown), then unpausing the game, will play previous song until the countdown finishes

Related issues: #16 #50

@sqirradotdev sqirradotdev changed the title No MainMenu music after playing/exiting level Music issues throughout the game Dec 10, 2020
@sqirradotdev sqirradotdev marked this pull request as draft December 10, 2020 04:21
@sqirradotdev sqirradotdev marked this pull request as ready for review December 10, 2020 05:18
@sqirradotdev sqirradotdev mentioned this pull request Dec 10, 2020
Closed
@ninjamuffin99
Copy link
Member

I'll dig into this PR in a smidge, just got update out so I got time now hehe

@ninjamuffin99 ninjamuffin99 merged commit 6756c83 into FunkinCrew:master Dec 13, 2020
@ninjamuffin99
Copy link
Member

LOOKS GOOD TO ME YOLO MERRRGE!

kudorado pushed a commit to kudorado/Funkin that referenced this pull request Jul 18, 2021
@ninjamuffin99
Merge pull request FunkinCrew#48 from gedehari/master
0cee421 
Music issues throughout the game
ninjamuffin99 added a commit that referenced this pull request Mar 9, 2023
@ninjamuffin99
Merge pull request #48 from gedehari/master
663fc0f 
Music issues throughout the game
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sqirradotdev @ninjamuffin99