Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error due to animation.setUpAnimation() #125

Closed
pbeneteau opened this issue Mar 1, 2017 · 11 comments
Closed

error due to animation.setUpAnimation() #125

pbeneteau opened this issue Mar 1, 2017 · 11 comments

Comments

@pbeneteau
Copy link

pbeneteau commented Mar 1, 2017

My app crash because of that function(EXC_BAD_ACCESS):

animation.setUpAnimation(in: layer, size: animationRect.size, color: color);

in NVActivityIndicatorView.swift line 456.

No logs.

@pbeneteau
Copy link
Author

pbeneteau commented Mar 1, 2017

Found solution: REPLACE first uppercase of type names by a lowercase.

@pbeneteau
Copy link
Author

Finally, it doesn't solve the problem...

@ninjaprox
Copy link
Owner

@stealdre: Could you provide more context of usage? (like code snippet, where using it). Since the example going the library is still working fine, the problem perhaps caused by other reason.

@pbeneteau
Copy link
Author

I tried to use it with both ways: storyboard and code. I created a view (50px50px) with the class NVActivityIndicatorView in the storyboard and with animation type and color. Then I start animating with:activityIndicatorView.startAnimating() and stop with activityIndicatorView.stopAnimating(). Not working. I also tried with the second way: code. I created a view with: NVActivityIndicatorView(frame: frame, type: type, color: color, padding: padding): not working. Same error for both ways: it makes crash the app. Then I tried the UI blocker which works perfectly. I did what is written in your Usage guide.

@ninjaprox
Copy link
Owner

@stealdre: How about the following simplest use?

let aiView = NVActivityIndicatorView(frame: CGRect(x: 0, y: 0, width: 100, height: 100))

aiView.color = .black
aiView.startAnimating()
view.addSubview(aiView)

@pbeneteau
Copy link
Author

This is working, try to update your guide.

@ninjaprox
Copy link
Owner

@stealdre: What's your suggestion for the better guide? PR is welcome.

@pbeneteau
Copy link
Author

pbeneteau commented Mar 2, 2017

Try first to create a guide that work! The current guide is not working like I said. I did exactly what it says. Then you give me a more easy way that works. Why not put this way in your guide?

@ninjaprox
Copy link
Owner

I think it's straightforward for most people and there's no such kind of this issue before. The guide itself is not a step-by-step tutorial and may require a minimal prerequisite to understanding. Hope you understand this. 😄

@pbeneteau
Copy link
Author

Hope people understand this...

@Oleksandr1234
Copy link

no its not, absolutely doesn't work, can't you just make it work without providing the frame? too much hassle, I tried other framework, work out of the box unlike this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants