APP_DEFAULT_MUC is not used when server doesn't advertise MUC in disco

[southerntofu]

When i misconfigured my XMPP vhost server-side, no MUC was advertised in XMPP disco, so xmpp-web didn't find a MUC, despite APP_DEFAULT_MUC being set to the correct value.

The error was on my side, and this "bug" enabled me to find out about it. However, i think it's counter intuitive that APP_DEFAULT_MUC is not used when no MUC server was advertised.

[nioc]

The APP_DEFAULT_MUC is the Docker environment variable linked to defaultMuc attribute in local.js. I suppose you set the attribute in local.js since you do not use docker image 😃.

Whatever, this information is only used to avoid to type the full jid when joining or creating a room but it is not enough for MUC usage (ie, if MUC is not advertised).

I can change the description to reflect this, do you have any suggestion?

[southerntofu]

I suppose you set the attribute in local.js since you do not use docker image smiley.

Correct :)

this information is only used to avoid to type the full jid when joining or creating a room but it is not enough for MUC usage

I noticed this is the current behavior. I'm wondering if this setting could also be used as a fallback when no MUC is advertised. Would this make anything more complex? Or do you think it's an entirely wrong approach?

do you have any suggestion?

If the setting keeps the same behavior, then maybe something like "Autocomplete join/create MUC addresses with this server. Does not configure the default MUC server on login ; this is determined by your XMPP server's discovery items." ?

But then maybe an explanation should be provided for the rationale for choosing the default MUC. Is it the first MUC found in discovery items? What happens when there's several of these?

[nioc]

I prefer to "keep it simple" 😆 and let XMPP library handling the MUC discovery / feed the public rooms list.
Attribute is only used for completing room full jid with the conference.domain.ltd. Users can still type the full jid in the create/join input.
I have slightly rewritten the doc.
I propose to close this issue if you agree.