Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room topic is displayed nowhere #78

Closed
Ppjet6 opened this issue Jan 28, 2023 · 13 comments
Closed

Room topic is displayed nowhere #78

Ppjet6 opened this issue Jan 28, 2023 · 13 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Ppjet6
Copy link
Contributor

Ppjet6 commented Jan 28, 2023

Is your feature request related to a problem? Please describe.
Room topic (<subject/>) contains information that may be important to users and it is displayed nowhere on xmpp-web. We use xmpp-web at Joinjabber for general user support and it would be useful for them to be aware of room rules when they join.

Describe the solution you'd like
Not entirely sure where I would like to see this.

The top bar seems already taken by the userlist/avatars, maybe starting from the other side? But that only works on bigger screens?
When joining the room, displayed within the chat?

Describe alternatives you've considered
It seems difficult to add this kind of information to room name. The room description seems to be used outside of the room mostly.
For our very specific use-case at joinjabber, we have common rules for our rooms so there could be a place somewhere in the room list where this is displayed.
Even though all users may not go through this as we also use the invite link guest?join=room.

@Ppjet6 Ppjet6 added the enhancement New feature or request label Jan 28, 2023
@nioc
Copy link
Owner

nioc commented Jan 28, 2023

I think 4 options are possible:

  • adding to the rooms list page (easy),
  • adding a line in chat message component (medium),
  • adding a tool tip when entering the room (medium),
  • adding a header like discussed in Display room information within the room #79 (complex).

@Ppjet6
Copy link
Contributor Author

Ppjet6 commented Jan 28, 2023

I am not sure I understand what you mean by "adding to the room list page". This is information that I think should also be available within the room.

EDIT: I thought I was answering to #79 sorry. I guess the best still is that this information be available within the room.

As for the other options, I think any of them would fit my personal requirements but maybe someone more qualified can comment.

@nioc
Copy link
Owner

nioc commented Jan 28, 2023

I was talking to add room subject to this component (roomS list, sorry for the typo on plural):
Screenshot_20230128-194029_Firefox Focus

@Ppjet6
Copy link
Contributor Author

Ppjet6 commented Jan 28, 2023

I just started gajim for unrelated reasons (not my usual client), and I actually like what they are doing. That is, some kind of tooltip on join inside the chat. It looks ok. What do you think?

@nioc
Copy link
Owner

nioc commented Jan 28, 2023

Are you talking about the second line in this demo chat on gajim (typo on Subjet... 😆 )?

28/01/2023 | 23:54:47  ‎nico a changé le sujet en Subjet 

screenshot

If yes, it was my thought saying "adding a line in chat message component (medium)" but I was not thinking to handle subject modification (a little bit more complex).

@Ppjet6
Copy link
Contributor Author

Ppjet6 commented Jan 28, 2023

20230129_00h07m26s_grim

It looks a bit better in gajim latest :)

For Joinjabber we don't need subject modification in xmpp-web but it would still be a nice addition anyway :)

@nioc
Copy link
Owner

nioc commented Jan 29, 2023

Yes, it is really better in this one (1.6, I presume?) than in the old 1.3.3 version I use 😆

👍🏻 Ok for this feature:

  • add a fake message in array with subject
  • maybe add a specific class for styling
  • maybe (no promise!), if it is not so complex, handling subject change by listening message with subject but not body neither thread element like the one in the xep:
<message
    from='coven@chat.shakespeare.lit/secondwitch'
    id='5BCE07C5-0729-4353-A6A3-ED9818C9B498'
    to='crone1@shakespeare.lit/desktop'
    type='groupchat'>
  <subject>Fire Burn and Cauldron Bubble!</subject>
</message>

@nioc nioc added this to the 0.9.6 milestone Jan 29, 2023
@Ppjet6
Copy link
Contributor Author

Ppjet6 commented Jan 29, 2023

For changing the subject, you can also discover whether you have permissions to do so:

  • Either you are a moderator, or
  • muc#roomconfig_changesubject is set to a truthy value. It's visible in the disco#info of the room, which I assume you do before joining.

@nioc
Copy link
Owner

nioc commented Jan 29, 2023

I propose to only handle subject changes, not to add UI for changing it from the web chat 😉

@nioc nioc self-assigned this Jan 29, 2023
@nioc
Copy link
Owner

nioc commented Jan 29, 2023

I just added a box on top which is always displayed with latest subject and author.
This is a first draft for UI:
image

May be adding a "dismiss" button for hiding it?

@nioc
Copy link
Owner

nioc commented Jan 29, 2023

A more complete version with the bulma message component:

image

Room jid is displayed as title.
The delete button is working for the room.

@nioc nioc closed this as completed in deeb849 Jan 29, 2023
@Ppjet6
Copy link
Contributor Author

Ppjet6 commented Feb 4, 2023

I'm replying here if it's ok.

The topic and room name appear properly in the chatroom, except that history is pull right after it is displayed and thus it's quickly scroll up, out of sight.

Would it be ok to display it after history has been added to the buffer?

@nioc
Copy link
Owner

nioc commented Feb 4, 2023

The fact is subject is displayed in a dedicated component (see line 17), not as a messages (which are in the for loop in lines 18~21).

Pulling history after or not will not change this behavior.

I do not think this is a real issue, as users entering in a room should read previous messages and so, subject.
But if your point is about dealing subject changes, this should be handled in another feature request (displayed in a programmatically toast for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants