Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate carpetplots even if MNI is not one of the output spaces #1119

Closed
oesteban opened this issue May 9, 2018 · 7 comments
Closed

Generate carpetplots even if MNI is not one of the output spaces #1119

oesteban opened this issue May 9, 2018 · 7 comments
Labels
confounds effort: high Estimated high effort task impact: high Estimated high impact task
Milestone
22.x

Comments

@oesteban
Copy link
Member

oesteban commented May 9, 2018

Right now, as it needs an atlas to grab labels from, this output space is necessary.
@oesteban oesteban mentioned this issue May 9, 2018
Merged
@effigies
Copy link
Member

effigies commented May 9, 2018

We should consider making a separate normalize flag, that ensures the T1-MNI transform gets calculated, even if no outputs are in that space. AROMA, SyN-SDC and now carpetplots all require this transform to exist.

@effigies
Copy link
Member

effigies commented May 9, 2018

Actually, I guess if carpetplots are always produced, then it's even easier: don't ever disable T1w-MNI registration, even if we don't save the registered series as derivatives.

@oesteban
Copy link
Member Author

oesteban commented May 9, 2018

That has been my temptation forever. But #808.

@effigies
Copy link
Member

effigies commented May 9, 2018

In that case, does it make sense to do EPI-MNI directly? The templates exist.

@oesteban
Copy link
Member Author

oesteban commented May 9, 2018

True that.

@oesteban oesteban added this to To do in pipelines via automation Jun 11, 2019
@oesteban oesteban added effort: high Estimated high effort task impact: high Estimated high impact task labels Jun 11, 2019
@franklin-feingold franklin-feingold moved this from To do to Issues B-list in pipelines Jun 21, 2019
@oesteban oesteban added this to the 2.0.0 milestone Jul 11, 2019
@oesteban oesteban moved this from Issues B-list to Issues C-list in pipelines May 8, 2020
@oesteban oesteban removed this from Issues C-list in pipelines Sep 29, 2020
@tsalo
Copy link
Collaborator

tsalo commented Dec 5, 2023

I believe MNI152NLin2009cAsym is automatically included as an internal transform target at this point, so I think this can be closed.

@effigies
Copy link
Member

effigies commented Dec 5, 2023

It is.

@effigies effigies closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confounds effort: high Estimated high effort task impact: high Estimated high impact task
Projects
None yet
Milestone
22.x
Development

No branches or pull requests
3 participants
@effigies @oesteban @tsalo