Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin-fix for memory issues fails in 1.2.1 #1363

Closed
markushs opened this issue Nov 5, 2018 · 4 comments · Fixed by #1368
Closed

Plugin-fix for memory issues fails in 1.2.1 #1363

markushs opened this issue Nov 5, 2018 · 4 comments · Fixed by #1368
Milestone

Comments

@markushs
Copy link
Contributor

markushs commented Nov 5, 2018

Hi!

We've been running large MB-datasets successfully using fmriprep 1.1.8 and the the "--use-plugin" argument (yaml file configured as in #1259).

However, when testing out version 1.2.1 we get the following error (on the same data with the same input parameters as in 1.1.8):

image

The error occurs immediately after the citation dump (i.e., before initiation of any workflows)

Here's the command:

image

And the content of the yaml-file:

image

We do not see the error when running fmriprep without the --use-plugin argument (however other issues arises, see #1365).

Any ideas?

Thanks!
Markus

(sorry about the screenshots - our data is stored in a secure environment that won't even let us copy-paste text)

@effigies
Copy link
Member

effigies commented Nov 5, 2018

Hmm. It's not obvious what the problem is, here. Is this a clean working directory (passed with -w), or, if not, does it still occur if you use a clean working directory?

@markushs
Copy link
Contributor Author

markushs commented Nov 5, 2018

Yes, I used a clean working directory. Replicated the issue with -vvvv. Not much more information, however:

image

@effigies
Copy link
Member

effigies commented Nov 5, 2018

Oh, I see. This is a nipype issue, related to fixes in nipy/nipype#2754, which was needed for Python 3.7 compatibility.

I'll submit a patch over there.

@effigies
Copy link
Member

effigies commented Nov 6, 2018

So I cannot for the life of me figure out how you're getting to the point where you're trying to pickle that particular object; I'm unable to write a test for my fix. Are you able to reproduce this problem on a local system where you can use fmriprep-docker? If so, then we should be able to test my fix without just releasing and seeing if it resolves your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants