Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that interpolation is NN above the EPI-to-T1w reportlet #1538

Closed
oesteban opened this issue Mar 13, 2019 · 4 comments
Closed

Indicate that interpolation is NN above the EPI-to-T1w reportlet #1538

oesteban opened this issue Mar 13, 2019 · 4 comments
Labels
effort: low Estimated low effort task impact: high Estimated high impact task reports

Comments

@oesteban
Copy link
Member

To avoid confusing the user (context: https://neurostars.org/t/fmriprep-weird-epi-t1-registration-artifact-problems/3811/2)

@oesteban oesteban added reports impact: high Estimated high impact task effort: low Estimated low effort task labels Mar 13, 2019
@oesteban oesteban added this to To do in Documentation via automation Mar 13, 2019
@sarenseeley
Copy link
Contributor

Hi @oesteban, I added some explanation to the lines you indicated. Specifically, I added "Note that Nearest Neighbor interpolation is used in the reportlets in order to highlight potential spin-history and other artifacts, whereas final images are resampled using Lanczos interpolation." Let me know if this explanation is not accurate, or if you'd like me to change it in some other way.

Here's the edited file: https://www.dropbox.com/s/y6vz4aq4nzl9749/config.json?dl=0

@oesteban
Copy link
Member Author

Hi @sarenseeley, would you mind creating a Pull Request for this?

Since you are modifying just one file, you should be able to add the explanation (which looks pretty good, IMHO) using this link https://github.com/poldracklab/fmriprep/edit/master/fmriprep/viz/config.json

The reason is that this way the changes will be assigned to your user and you'll become an fMRIPrep contributor.

@sarenseeley
Copy link
Contributor

Done. Hopefully I did this correctly...

@oesteban
Copy link
Member Author

You did! Thanks!

Documentation automation moved this from To do to Done Jun 11, 2019
@oesteban oesteban removed this from Done in Documentation Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Estimated low effort task impact: high Estimated high impact task reports
Projects
None yet
Development

No branches or pull requests

2 participants