New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split into separate fit & apply workflows #3058
Comments
Below are the notes that came out of our discussions at the brainhack (originally compiled at https://hackmd.io/@effigies/fmriprep-fit). Thank you for the discussions, @feilong @HippocampusGirl @mgxd @oesteban. Minimal derivatives
Dependency structuregraph TB;
bold.nii --> desc-hmc_boldref.nii;
desc-hmc_boldref.nii-->from-orig_to-boldref_xfm.txt;
desc-hmc_boldref.nii-->from-fmap_to-boldref_xfm.txt;
sbref.nii--->from-coreg_boldref.nii;
desc-hmc_boldref.nii-->from-coreg_boldref.nii;
from-coreg_boldref.nii-->from-boldref_to-T1w_xfm.txt;
Application notesgraph TD;
bold.nii -- slice-timing correction --> desc-stc_bold.nii;
desc-stc_bold.nii -- split --> idx-*_desc-stc_bold.nii;
space-boldref_bold.nii --> desc-confounds_timeseries.tsv;
idx-*_desc-stc_bold.nii -- resample and merge -->
space-boldref_bold.nii & space-*_bold.nii & hemi-L_space-fsnative_bold.func.gii & hemi-R_space-fsnative_bold.func.gii;
space-*_bold.nii -- select space-MNI152NLin6Asym ---> space-fsLR_bold.dtseries.nii;
hemi-L_space-fsnative_bold.func.gii -- resample --> hemi-L_space-fsLR_bold.func.gii;
hemi-R_space-fsnative_bold.func.gii -- resample --> hemi-R_space-fsLR_bold.func.gii;
hemi-L_space-fsLR_bold.func.gii & hemi-R_space-fsLR_bold.func.gii
--> space-fsLR_bold.dtseries.nii;
Single-shot surface resampling changes
|
Please see here some example weight files from _hemi_R_volume_to_surface_output_weights.txt |
Yes, that looks very straightforward. We should test to make sure we get the same result to within reasonable precision. Would you mind pushing a branch with your patch? |
Each line seems to be:
What puzzles me a bit is that the sum of the weights don't add up to one. Other parts look quite straightforward to me, too. |
I've uploaded the code at https://github.com/HippocampusGirl/fmriprep/tree/output-weights-text. It's not really ready for a PR yet, because I guess we wouldn't want to do this with the real data in |
Right we won't use it this way in the long run, but this is totally fine for getting an output that we can test on. |
@feilong What is the minimal set of surfaces we need for resampling? I'll skip |
@effigies Yes. Definitely If the original |
This is done. |
Relevant issues:
smriprep implementation: nipreps/smriprep#303
The text was updated successfully, but these errors were encountered: