WIP: Fix isnan windows #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC does not have `isnan` or `log2` defined in `math.h` - use the numpy math header and code to provide versions that should work on all platforms that numpy works on.
Get PI from `npy_math.h`
Linker not finding `npy_log`
to silence compiler warning
|
I haven't tested this one on Windows yet. Please don't merge. |
|
Tested, works on windows, ready to merge as far as I am concerned. |
|
The idea to move definitions to dpy_math.h seems very good to me. I didn't know you had to update that information in MANIFEST with the src foulder. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use numpy includes and code fragments to make dipy compilation more portable across platforms and compilers; in particular, make dipy compile on MS Visual C++.