New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Use the CFIN dataset rather than the CENIR dataset. #1424
ENH: Use the CFIN dataset rather than the CENIR dataset. #1424
Conversation
e6c97b1
to
9190ba6
Compare
I removed the
sentence from the documentation since Finally, I got an error while debugging the example:
at
If CI builds do not report issues, I can assume this is a local issue, and that our |
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 87.51% 87.49% -0.02%
==========================================
Files 241 241
Lines 30724 30724
Branches 3326 3326
==========================================
- Hits 26887 26883 -4
- Misses 3060 3063 +3
- Partials 777 778 +1
Continue to review full report at Codecov.
|
Looks like CircleCI containers do have the I've noticed that the |
Can you review this PR @arokem? |
Will do! |
Moving to this new dataset will require some additional changes. See jhlegarreta#1 |
Thanks for the review @arokem ! |
Thank you! I am +1 for merging this. If someone else could take a look, that would be great. |
After PR: mapmri using cvxpy instead of cvxopt #1285, we are now using package CVXPY instead of CVXOPT, I think we need to update the comment on line 27-31 in reconst_mapmripy for this. |
d768bc4
to
801a42f
Compare
Thanks for the comments. @RicciWoo @arokem Please see whether commit 801a42f addresses adequately this. I did not add the reference to the I haven't mentioned the conda part, since this a more general comment, applicable to any package. |
Hi @jhlegarreta, I got this error when I tried to run this example with the new dataset:
I am working on Windows. Do you get this error ? Can you update the plotting part. |
801a42f
to
795aa4f
Compare
@skoudoro thanks for the review. I did get the same error. Please, check if commit 795aa4f solves the plot part issues. Also, I am getting an error at
telling me that
Let's see what CI says, or whether you do get the same error; if you do, I'll amend with
BTW, although I know other parts of the code use May be this is a Windows-specific issue (?) |
Looks like travis is happy; may be because no image is run on Windows machines (?). @skoudoro let me know when you check the patch set. |
It's because the examples are not run as part of the CI. That would take
way too long.
…On Sat, Apr 7, 2018 at 6:30 PM, Jon Haitz Legarreta Gorroño < ***@***.***> wrote:
Looks like travis is happy; may be because no image is run on Windows
machines (?). @skoudoro <https://github.com/skoudoro> let me know when
you check the patch set.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1424 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHPNtnZ0IyEAsLuCWIxDubeTPD262Kkks5tmQW9gaJpZM4SBXE6>
.
|
Thanks @jhlegarreta. Today, I do not have access to my windows machine so I will try it tomorrow. Concerning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jhlegarreta, the new dataset has this shape (96,96,19,496)
so can you update the crop to make it work? look at the line here and replace it with something like data[40:65, 50:51]
Can you rebase this PR?
thanks!
Following the discussion in dipy#1291, use the ``CFIN`` dataset instead of the ``CENIR`` dataset. Also, make an explicit mention to the `MAPL` acronym so that the use of the Laplacian-regularized MAP-MRI method seems no longer to be hidden.
795aa4f
to
3eb7ddb
Compare
In interactive mode, all results seem good when we display them, so maybe a saving issue, I will look at that |
OK. Let me know if you are able to reproduce the issue (working on Win 10); if not, may be it's local to my environment and we can ignore it. Thanks Serge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jhlegarreta, below, the answer of black images.
Can you add sfu.RotateX(-90)
line 390
It will be ready to merge after all this change.
Thank you @jhlegarreta
rtop_laplacian = np.array(mapfit_laplacian_aniso.rtop()[:, 0, :].T, | ||
dtype=float) | ||
ind = ax1.imshow(rtop_laplacian, interpolation='nearest', | ||
origin='lower', cmap=plt.cm.gray, vmin=0, vmax=5e7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vmin
and vmax
are incorrect. This wrong range is the reason for your black image. Can you just remove this 2 parameters and let matplotlib
manage it
rtop_positivity = np.array(mapfit_positivity_aniso.rtop()[:, 0, :].T, | ||
dtype=float) | ||
ind = ax2.imshow(rtop_positivity, interpolation='nearest', | ||
origin='lower', cmap=plt.cm.gray, vmin=0, vmax=5e7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vmin
and vmax
are incorrect. This wrong range is the reason for your black image. Can you just remove this 2 parameters and let matplotlib
manage it
vmin=0, vmax=5e7) | ||
rtop_both = np.array(mapfit_both_aniso.rtop()[:, 0, :].T, dtype=float) | ||
ind = ax3.imshow(rtop_both, interpolation='nearest', origin='lower', | ||
cmap=plt.cm.gray, vmin=0, vmax=5e7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vmin
and vmax
are incorrect. This wrong range is the reason for your black image. Can you just remove this 2 parameters and let matplotlib
manage it
Due to the release, I will merge it and make the last correction on new PR. Thank you @jhlegarreta for this PR and @arokem for this review! |
…taInReconstMAPMRIExample ENH: Use the CFIN dataset rather than the CENIR dataset.
Following the discussion in #1291, use the
CFIN
dataset instead ofthe
CENIR
dataset.Also, make an explicit mention to the
MAPL
acronym so that the use ofthe Laplacian-regularized MAP-MRI method seems no longer to be hidden.