New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"incompatible" import of peaks_from_model in your recent publication #328
Comments
Yep, that should definitely have been:
This is still labeled "provisional pdf" on the Frontiers web-site. Any On Wed, Feb 19, 2014 at 9:32 AM, kodiweera notifications@github.com wrote:
|
Maybe there is still time if we are lucky. Just sent them a message. Thank you @kodiweera |
How do you guys feel about importing peaks_from_model into the Bago On Wed, Feb 19, 2014 at 10:14 AM, Eleftherios Garyfallidis <
|
There are few more typos in it. so far I encountered the following. For consistency, it should be And also, in the page 7, you have For consistency, it should be will let you know if there are more typos! |
Thank you @kodiweera but from what I see now the frontiers website does not allow any more changes on our side. Let's not drive ourselves crazy here. There will always be some typos here and there. It's okay. @MrBago I really don't think that what you suggest is necessary to do. Anyone having problems with peaks_from_model the first thing to do would be to google the function online or look at the tutorials and if you do that you will find the correct version. Let's move forward guys. |
We all know that dipy is going to explode with this paper :) so I just want Bago On Wed, Feb 19, 2014 at 11:46 AM, Eleftherios Garyfallidis <
|
I think the change to peaks was the last comment which I was allowed to do in Frontier's website for the Dipy paper. Fingers' crossed I hope the Frontiers' typesetters will make the change. Cannot say for sure yet. I will let you know if they get back to me. |
Okay, I just sent an e-mail directly to Frontiers' production office with all the corrections suggested by @kodiweera. I hope it goes through. Thanx again @kodiweera. |
Seems like it worked! Thanks @kodiweera, and thanks @Garyfallidis for On Wed, Feb 19, 2014 at 12:51 PM, Eleftherios Garyfallidis <
|
It seems to be done, I close |
I was following code in your recent DiPy paper in frontiers (using recent 0.7.1 release). While in the section 6.5, I typed "from dipy.reconstruct.odf import peaks_from_model" which resulted in ImportError because in 0.6.0-564-gbdeca9e you refactored it into a separate peaks submodule. It would be nice if current 0.7.x stayed compatible with at least the code in the reference DiPy publication!
Thank you in advance!
The text was updated successfully, but these errors were encountered: