TST - skip doctest when matplotlib is not available #58
Conversation
| has_mpl=False | ||
| hot = None | ||
| plt = None | ||
| matplotlib, has_mpl, setup_module = optional_package("matplotlib") |
There was a problem hiding this comment.
We can just import matplotlib.pyplot -- matplotlib.pyplot.cm.hot is the colormap we use later.
|
So, the question is whether these errors should be raised on import or on first use. Previously, this was a much bigger problem, but since we now require explicit imports of submodules it's probably not so bad. Still, I think it's better to do it on first use. E.g., I want to be able to use matplotlib-reliant functions, even if Mayavi is not installed. |
|
That's exactly what optional import does. If the import fails, it creates a TripWire instead. The first time someone tries to use the missing module or package an error is raised. I thought I would need to make a decorator to tell nose to skip the tests when the imports fail, but Matthew has already taken care of that too. |
|
Excellent, now I understand the TripWire concept too :) |
TST - skip doctest when matplotlib is not available
It seems like somebody has already solved this problem for us. This will replace #57