Fvtk 2.0 PR1 #587

Garyfallidis · 2015-03-11T15:15:14Z

This will make you happy @arokem and @stefanv! Moving forward with the visualization capabilities of DIPY!!! The PR is ready for a review.

This pull request introduces a new API for visualization.

Here are the main characteristics:
a) Allows for testable screenshots and renderers. Which is crucial for quality assurance.
b) It contains 3 main modules (window, actor and widget). These are replacing the current fvtk module but fvtk can be used too for backwards compatibility.
c) In window we have everything related to windowing, rendering and saving screenshots.
d) In actor you will find the actors for lines and streamtubes etc. Not everything has moved yet from fvtk.py so that the PR doesn't become too large. But all actors should move in the next PRs.
e) In widget we have buttons and sliders which can be used directly from inside OpenGL/VTK. No new dependencies.
d) You can save and open file dialogues using Tk which is ported together with Python. No new dependencies.
f) Because they are a lot of new concepts and ideas in this PR I wrote 4 tutorials to help the reviewing process.

Let me know what you think.

…n recording becomes too fast

…ow has changed

…n process

arokem · 2015-10-30T02:45:55Z

Oh no - wait - you're right. There's one: "No VTK for these tests" in there
as well.

Let me double check again...

On Thu, Oct 29, 2015 at 7:24 PM, Ariel Rokem arokem@gmail.com wrote:

Yeah - those are other test-conditions that are causing those to be
skipped. I think this is about importing the vtk colors module. Maybe we
can take that separately?

On Thu, Oct 29, 2015 at 6:15 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

@arokem https://github.com/arokem just to make sure here. On top of
which branch do I need to rebase this one? Is it #752
#752? Because I see some vtk tests
are skipped there. But maybe this is normal for that version of the code.
Sorry in advance for the naivety of the question, it's getting late here
and I had a long day. :) But hey no excuses! Let's get the new viz in!

—
Reply to this email directly or view it on GitHub
#587 (comment).

arokem · 2015-10-30T12:12:24Z

OK - I am about ready to say that we can't test some of these things on
Travis. I propose setting this to skip on Travis.

If you rebase this on master, I can make a PR against your branch with the
proposed changes to make that happen.

On Thu, Oct 29, 2015 at 7:45 PM, Ariel Rokem arokem@gmail.com wrote:

Oh no - wait - you're right. There's one: "No VTK for these tests" in
there as well.

Let me double check again...

On Thu, Oct 29, 2015 at 7:24 PM, Ariel Rokem arokem@gmail.com wrote:

Yeah - those are other test-conditions that are causing those to be
skipped. I think this is about importing the vtk colors module. Maybe we
can take that separately?

On Thu, Oct 29, 2015 at 6:15 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

@arokem https://github.com/arokem just to make sure here. On top of
which branch do I need to rebase this one? Is it #752
#752? Because I see some vtk tests
are skipped there. But maybe this is normal for that version of the code.
Sorry in advance for the naivety of the question, it's getting late here
and I had a long day. :) But hey no excuses! Let's get the new viz in!

—
Reply to this email directly or view it on GitHub
#587 (comment).

Run xvfb with screen server-arg

Don't use xvfb in the call to nosetests. Only test the one we are interested in for now. I guess it needs to be included to actually run? Copy over this decorator to test_fvtk_widgets to get it running under xvfb. Are we there yet?

…ywhere.

Fvtk2 travis

Add another bot to test on vtk6

…window appears) depth peeling is not supported but if you allow for a quick window to appear then transparent ordering works fine.

…ut it works fine in standard displays. Added if statement to deal with this issue

TST: Add python-imaging

…pdated fast enough

Fvtk 2.0 PR1

arokem · 2015-11-01T21:59:33Z

Congratulations @Garyfallidis! A new era of diffusion MRI visualization!

Garyfallidis · 2015-11-01T22:04:06Z

Oh man it has been a looooong trip! I am so pleased :) Things are getting exciting! @MarcCote first dipy.viz PR is in!!! You know exactly what that means! Mayhem!!! @arokem many thx for the great help on setting up VTK on mad Travis. 👯

Garyfallidis · 2015-11-01T22:04:57Z

Let's start making some smaller viz PRs from now on. 👍

arokem · 2015-11-01T22:05:54Z

+1

On Sun, Nov 1, 2015 at 2:04 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Let's start making some smaller viz PRs from now on. [image: 👍] This
one was a bit too big.

—
Reply to this email directly or view it on GitHub
#587 (comment).

Garyfallidis added 30 commits March 4, 2015 14:47

NF: Dipy version is now shown in the fvtk window

bf9f3d0

Created new example

1a2dc52

NF: adding buttons is now possible but without normalized coordinates

60e7b5d

Added link for infor on normalized coordinates

828e1ac

The button's rep (PlaceWidget) has to be called after Window render

0030bd4

Example now supports native img coords or world coords

ac9e790

BF: Added 1 second delay before recording. This resolves problems whe…

18bb7e2

…n recording becomes too fast

pep8

519b8d7

NF: added support for offscreen snapshot

7b9ec04

Starting looking into plotting bundles with maps

3ce90ba

Small update in interact_data

6669f34

RF: minor changes

6fa127e

Moved analyze snapshot to window

dcc8a08

RF: renderer parameter is now ren for backwards compatibility

8b225e7

Setting good coordinates for buttons

0696aab

Still debugging buttons

c00a610

looking for icons

bcb943a

NF: button widget has a new method for updating coordinates when wind…

1513c77

…ow has changed

Checking button alignment on resize

12f2c12

Looking for better ways to analyze the snapshots

c61cdeb

NF: analyze_snapshot can find specific colors and objects

63975c9

Looking at a possible bug with the tmpdir and snapshot

5fcd1ea

BF: changed default parameter for find_objects

0eec3ef

RF: when recording many videos now there are leading zeros

c9791a4

NF: dialog appears when saving snapshots from show

75d407b

RF: made independed save dialog function

88e3450

NF: Added fetcher to download icons and updated test for widgets

3db47ca

PEP 8 in fetcher.py

0cb5b0f

More PEP 8 in the same file

264300c

NF: made new class which separates the window creation and interactio…

1f1ab2c

…n process

Garyfallidis and others added 8 commits October 30, 2015 13:02

Merge branch 'nipy-dipy-master' into fvtk_2.0

6d82cba

Run xvfb with screen server-arg

fb38779

Merge pull request #37 from arokem/fvtk2-travis

3641705

Run xvfb with screen server-arg

Use xvfbwrapper on travis.

267d8a1

Don't use xvfb in the call to nosetests. Only test the one we are interested in for now. I guess it needs to be included to actually run? Copy over this decorator to test_fvtk_widgets to get it running under xvfb. Are we there yet?

Integrate the xvfb_it decorators into the testing module and use ever…

28eefd2

…ywhere.

TST: Insert back the function name when decorated with xvfb_it

13c8b7a

TST: Generalize the variable names a bit. Add comment to explain.

9e0683e

TST: Add back a few more test machines.

03b12a9

arokem mentioned this pull request Oct 31, 2015

Fvtk2 travis Garyfallidis/dipy#38

Merged

Garyfallidis and others added 13 commits October 30, 2015 20:20

Merge pull request #38 from arokem/fvtk2-travis

e04f288

Fvtk2 travis

Add another bot to test on vtk6

4052a0b

Merge pull request #39 from arokem/fvtk2-travis

dd96894

Add another bot to test on vtk6

BF: In some GPUs when you use snapshot with complete stealthmode (no …

240f91c

…window appears) depth peeling is not supported but if you allow for a quick window to appear then transparent ordering works fine.

Default xvfb display size is changed to HD 1920x1080

91a3c6f

TST: Add python-imaging

5568302

BF+TEST: In xvfb offscreen rendering with True returns black window b…

9bc93a9

…ut it works fine in standard displays. Added if statement to deal with this issue

Merge pull request #40 from arokem/fvtk2-travis

4b24100

TST: Add python-imaging

TST: removed updated and used display_extent instead

05cecb3

Merge branch 'fvtk_2.0' of github.com:Garyfallidis/dipy into fvtk_2.0

0748794

TST: I am assuming that rendering was too fast and snapshot was not u…

748de39

…pdated fast enough

Trying to enforce displaying the actor

3eb2b4f

Debugging with VTK=1

b590ca0

arokem added a commit that referenced this pull request Nov 1, 2015

Merge pull request #587 from Garyfallidis/fvtk_2.0

d90ee2a

Fvtk 2.0 PR1

arokem merged commit d90ee2a into dipy:master Nov 1, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fvtk 2.0 PR1 #587

Fvtk 2.0 PR1 #587

Garyfallidis commented Mar 11, 2015

arokem commented Oct 30, 2015

arokem commented Oct 30, 2015

arokem commented Nov 1, 2015

Garyfallidis commented Nov 1, 2015

Garyfallidis commented Nov 1, 2015

arokem commented Nov 1, 2015

Fvtk 2.0 PR1 #587

Fvtk 2.0 PR1 #587

Conversation

Garyfallidis commented Mar 11, 2015

arokem commented Oct 30, 2015

arokem commented Oct 30, 2015

arokem commented Nov 1, 2015

Garyfallidis commented Nov 1, 2015

Garyfallidis commented Nov 1, 2015

arokem commented Nov 1, 2015