A few fixes to SFM. #816
Merged
A few fixes to SFM. #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
changed the title
|
Changed this to WIP, because I need to do a couple more things in here. |
arokem
force-pushed
the
update-sfm-reference
branch
2 times, most recently
from
5b0c913
to
d835662
Compare
|
This is ready for review. I managed to remove many of the warnings that arise here. The remaining ones would require some bending over backward, that I would rather avoid, because it would make the code hard to read, or slower to run (unless someone has some good suggestion...). |
|
|
||
| Returns | ||
| ------- | ||
| ndarray : each column is a rotated version of the response function. |
There was a problem hiding this comment.
Non standard docstring for parameter explanation
|
OK - I have addressed your comment. |
arokem
force-pushed
the
update-sfm-reference
branch
from
d835662
to
f3ace86
Compare
|
And rebased. |
arokem
force-pushed
the
update-sfm-reference
branch
from
f3ace86
to
6352256
Compare
|
Now rebased again, to drop the 3.2 Travis build that was failing. |
…ments: - Code repetition removed by creating a helper function for isotropic models. - Performance improvement by using the isotropic predictor only once, instead of in every iteration. - Error handling: checking of mask appropriateness.
arokem
force-pushed
the
update-sfm-reference
branch
from
6352256
to
bb88df5
Compare
|
Rebased again. Could someone please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous reference was to a preprint that is now superseded by a peer-reviewed publication.