PEP8 in sims #884 #960
PEP8 in sims #884 #960
Conversation
| @@ -55,32 +55,32 @@ def test_phantom(): | |||
| FA[np.isnan(FA)] = 0 | |||
| # 686 -> expected FA given diffusivities of [1500, 400, 400] | |||
| l1, l2, l3 = 1500e-6, 400e-6, 400e-6 | |||
| expected_fa = (np.sqrt(0.5) * np.sqrt((l1 - l2)**2 + (l2-l3)**2 + (l3-l1)**2 )/np.sqrt(l1**2 + l2**2 + l3**2)) | |||
| expected_fa = np.sqrt(0.5) * np.sqrt((l1 - l2)**2 + (l2 - l3)**2 + (l3 - l1)**2) / np.sqrt(l1**2 + l2**2 + l3**2)) | |||
There was a problem hiding this comment.
This line is probably still >80 characters long. A suggestion:
expected_fa = (np.sqrt(0.5) * np.sqrt((l1 - l2)**2 +
(l2 - l3)**2 + (l3 - l1)**2) /
np.sqrt(l1**2 + l2**2 + l3**2)))
|
Thanks for taking a look! Just a couple of small comments. |
|
Fixing em in 5! :) On Thu, Mar 3, 2016 at 2:16 AM, Ariel Rokem notifications@github.com
|
|
Can you check now @arokem ? |
| # r=fvtk.ren() | ||
| # fvtk.add(r,fvtk.volume(vol234[...,0])) | ||
| # fvtk.show(r) | ||
| # vol234n=add_rician_noise(vol234,20) |
There was a problem hiding this comment.
Somebody might want to clean this up at some point, but maybe not on this PR.
|
LGTM. Someone else want to take a look here? |
| expected_fa = (np.sqrt(0.5) * np.sqrt((l1 - l2)**2 + (l2-l3)**2 + (l3-l1)**2 )/np.sqrt(l1**2 + l2**2 + l3**2)) | ||
| expected_fa = (np.sqrt(0.5) * np.sqrt((l1 - l2)**2 + | ||
| (l2 - l3)**2 + (l3 - l1)**2) / | ||
| np.sqrt(l1**2 + l2**2 + l3**2))) |
There was a problem hiding this comment.
np.sqrt(l1**2 + l2**2 + l3**2))
remove extra brackets.
There was a problem hiding this comment.
Yup. That's probably my bad for suggesting this. See failing tests:
|
Closing for now. |
Fixes #884