Fixes #1016 : Raises VTK not installed #1017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Garyfallidis @arokem I closed this issue and reverted back to the previous state as it appears that when packages are not installed the optional_pakage function from utils.optpkg takes care of the import error. Instead of raising an error it returns a TripWire message as the import. Calling any attribute of this TripWire object should raise the ImportError and print the message. Example. vtk, have_vtk, setup_module = optional_package('vtk')
ren = vtk.ren()Should show the TripWire error. But it doesn't. fvtk documentation says "# Allow import, but disable doctests if we don't have vtk" I tried with other optional packages like tables in io.dpy and it was giving me the expected TripWire error. I will dig into it. Any comments from your side would be helpful. |
This was referenced Mar 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs the user that VTK is not installed.