New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1016 : Raises VTK not installed #1017

Closed
wants to merge 0 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@sahmed95
Contributor

sahmed95 commented Mar 23, 2016

Informs the user that VTK is not installed.

@sahmed95 sahmed95 closed this Mar 24, 2016

@sahmed95 sahmed95 force-pushed the sahmed95:issue-1016 branch from 0fc3549 to 6bff565 Mar 24, 2016

@sahmed95 sahmed95 deleted the sahmed95:issue-1016 branch Mar 24, 2016

@sahmed95 sahmed95 restored the sahmed95:issue-1016 branch Mar 24, 2016

@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented Mar 24, 2016

Hi, @Garyfallidis @arokem I closed this issue and reverted back to the previous state as it appears that when packages are not installed the optional_pakage function from utils.optpkg takes care of the import error. Instead of raising an error it returns a TripWire message as the import. Calling any attribute of this TripWire object should raise the ImportError and print the message. Example.
Thus if VTK is not installed.

vtk, have_vtk, setup_module = optional_package('vtk')
ren = vtk.ren()

Should show the TripWire error. But it doesn't.

fvtk documentation says "# Allow import, but disable doctests if we don't have vtk" I tried with other optional packages like tables in io.dpy and it was giving me the expected TripWire error. I will dig into it. Any comments from your side would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment