Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding parallel_voxel_fit decorator #1418
You just need to add this decorator (
To define the number of processors, you just need to do:
Currently, all the code is in
Note: In order for multiprocessing to be beneficial, the fitting task needs to be significant. Significant means bigger than the overhead created by multiprocessing during inter-process communication. If it is not the case, use
I didn't really check the code because I'm not too sure what it'll do, but here are some minor things.
Hello @skoudoro, Thank you for updating !
Comment last updated on August 21, 2018 at 16:52 Hours UTC
@@ Coverage Diff @@ ## master #1418 +/- ## ========================================== - Coverage 87.32% 87.22% -0.11% ========================================== Files 246 248 +2 Lines 31806 31936 +130 Branches 3450 3467 +17 ========================================== + Hits 27775 27855 +80 - Misses 3210 3249 +39 - Partials 821 832 +11
Generally looks good. I had a couple of comments.
Have you had a chance to profile this? Does it really lead to any improvement in a realistic test-case?
Also - could you please rebase this on master? I think that at least some of the test failures should be resolved now.