[Fix] viz slice example #1622
Merged
[Fix] viz slice example #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 246 245 -1
Lines 32164 32148 -16
Branches 3497 3493 -4
==========================================
- Hits 28089 28073 -16
Misses 3242 3242
Partials 833 833
Continue to review full report at Codecov.
|
arokem
reviewed
Aug 22, 2018
| @@ -170,8 +170,8 @@ | |||
|
|
|||
| lengths = length(bundle_native) | |||
|
|
|||
| hue = [0.5, 0.5] # red only | |||
There was a problem hiding this comment.
I am confused by the comment here. This is the same as above, so how could they both be red only?
There was a problem hiding this comment.
Good catch! should be blue here. here the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viz slice example was broken because of the
viznew grid system so this is just an update.