From dipy.viz to FURY

[skoudoro]

• Remove fvtk module
• dipy.viz give birth to FURY --> New Scientific visualization library

More information about FURY:

• Fury Github: https://github.com/fury-gl/fury
• Fury Documentation: https://fury.gl

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@c0daaeb). Click here to learn what that means.
The diff coverage is 90.9%.

@@            Coverage Diff            @@
##             master    #1659   +/-   ##
=========================================
  Coverage          ?   88.45%           
=========================================
  Files             ?      233           
  Lines             ?    29233           
  Branches          ?     3217           
=========================================
  Hits              ?    25859           
  Misses            ?     2704           
  Partials          ?      670

Impacted Files	Coverage Δ
dipy/data/__init__.py	83% <ø> (ø)
dipy/data/fetcher.py	33.24% <ø> (ø)
dipy/viz/__init__.py	90% <100%> (ø)
dipy/io/vtk.py	14.58% <75%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0daaeb...6ecd63d. Read the comment docs.

[arokem]

OK. This all looks good to me.

Do you want to add some documentation here pointing to Fury? I think that you mention it where we previously pointed to VTK, but I would add a link there, so that people can easily find it.

[skoudoro]

Do you want to add some documentation here pointing to Fury?

I do not understand. Do you mean adding this 2 links:

• Fury Github: https://github.com/fury-gl/fury
• Fury Documentation: https://fury.gl

or something else?

[arokem]

Yes: the fury documentation link (https://fury.gl) should be somewhere in our docs. Is it somewhere in this PR?

…

On Fri, Nov 9, 2018 at 1:21 PM Serge Koudoro ***@***.***> wrote: Do you want to add some documentation here pointing to Fury? I do not understand. Do you mean adding this 2 links: - Fury Github: https://github.com/fury-gl/fury - Fury Documentation: https://fury.gl or something else? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1659 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHPNkUUZZtX-BYm4XtyB3XN355TPxeeks5utfHqgaJpZM4YAmlw> .

[skoudoro]

oh ok, It is not, you are right. I do not know yet where to put it but will do

[arokem]

How about in the installation instructions?

…

On Fri, Nov 9, 2018 at 1:33 PM Serge Koudoro ***@***.***> wrote: oh ok, It is not, you are right. I do not know yet where to put it but will do — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1659 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHPNnaswunK1us0I-vqvdtEYjdz3h0Mks5utfS8gaJpZM4YAmlw> .

[Garyfallidis]

@skoudoro remind me something this function stays in DIPY because we want to have surface loading support? Or there is some other reason? I thought the idea was to remove direct dependencies to vtk. And only indirectly depend through FURY?

[Garyfallidis]

By the way this is not a suggestion to move io to FURY right now. But something to think for release 0.16.

[Garyfallidis]

+1 for @arokem suggestion to update documentation (and installation instructions) with Fury.
Otherwise this look ready! :)

[skoudoro]

Thanks @arokem and @Garyfallidis for the review. I added the documentation link and fix io/vtk.

It looks like it is ready to go! Can you have a last check?

[Garyfallidis]

Great work! To Inf+!