Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in release notes #1690

Merged
merged 3 commits into from Dec 17, 2018
Merged

Typo in release notes #1690

merged 3 commits into from Dec 17, 2018

Conversation

arokem
Copy link
Contributor

@arokem arokem commented Dec 14, 2018

Sorry for only noticing this now. I do believe @wasserth spells his name with a "K": https://www.dkfz.de/en/mic/team/people/Jakob_Wasserthal.html

@skoudoro
Copy link
Member

good catch! Sorry about that...

Can you correct it on AUTHOR file and .mailmap file?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7e689f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1690   +/-   ##
=========================================
  Coverage          ?   84.25%           
=========================================
  Files             ?      114           
  Lines             ?    13557           
  Branches          ?     2139           
=========================================
  Hits              ?    11422           
  Misses            ?     1638           
  Partials          ?      497

@wasserth
Copy link
Contributor

With "k" is the correct spelling. Thanks for spotting that typo ;).

@skoudoro
Copy link
Member

Can you update AUTHOR file and .mailmap file too @arokem?

@arokem
Copy link
Contributor Author

arokem commented Dec 17, 2018

done!

@skoudoro
Copy link
Member

Great, Thank you! merging!

@skoudoro skoudoro merged commit f2c6437 into master Dec 17, 2018
@skoudoro skoudoro deleted the typo-jakob branch July 1, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants