[FIX] mapmri with cvxpy 1.0.15 #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would we still need this if we skip this version of cvxpy and pin to 1.0.14 (as in #1695)? |
|
I think so, even if we make Travis happy, any new users or if someone works with master and does an update of |
|
Strange bug indeed. Instead of arbitrarily setting the minimum lopt to 1e-20, perhaps it's cleaner to solve the problem without the regularization term if lopt == 0, and avoid the bug altogether. |
|
Ok, thank you for your feedback @rutgerfick. implemented on 014b57f |
|
+1. Will merge as soon as the CI comes back |
|
Thanks for implementing this! |
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
==========================================
+ Coverage 84.26% 84.26% +<.01%
==========================================
Files 115 115
Lines 13606 13608 +2
Branches 2144 2145 +1
==========================================
+ Hits 11465 11467 +2
Misses 1643 1643
Partials 498 498
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround to fix our problem with
cvxpy 1.0.15on Mapmri. More details on this issue https://github.com/cvxgrp/cvxpy/issues/672.I would like to know by the MapMRI expert (@rutgerfick @RafaelNH @arokem @Garyfallidis) if this approximation is ok or not.
Thank you for your feedback