jupyter notebooks from examples #1778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @arokem, Thank you for updating !
Comment last updated at 2019-05-08 19:43:26 UTC |
|
Still needs some more cleaning up. The rendered notebooks will include (for example) figure blocks from the original rst and other crufy, so we need to process the cells even further. Will follow up with that, before marking this as "ready for review" |
arokem
force-pushed
the
issue-720_notebooks
branch
from
940ee97
to
046527b
Compare
Borda
reviewed
Apr 27, 2019
| cells.append(textcells[i]) | ||
| cells.append(codecells[i]) | ||
| except: | ||
| pass |
There was a problem hiding this comment.
just pass is not best practice... :)
| """ | ||
|
|
||
| file_path = os.path.join(directory, fname) | ||
| f = open(file_path, "r") |
There was a problem hiding this comment.
rather use with statement
with open(file_path, 'r') as fp:
fdata = fp.read()
| """Get the valid examples to be converted""" | ||
| flist_name = pjoin(os.path.dirname(os.getcwd()), 'doc', 'examples', | ||
| 'valid_examples.txt') | ||
| flist = open(flist_name, "r") |
There was a problem hiding this comment.
again, rather use with statement
| for example in validated_examples: | ||
| fullpath = pjoin(EG_SRC_DIR, example) | ||
| if not example.endswith(".py"): | ||
| print("%s not a python file, skipping." % example) |
There was a problem hiding this comment.
why not using logging module?
Now we just need to clean things up in the rst => ipynb conversion.
arokem
force-pushed
the
issue-720_notebooks
branch
from
046527b
to
a81705b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work in #1022 and supersedes it.