Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users if they don't have FURY installed #1902

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@arokem
Copy link
Member

commented Jul 16, 2019

And provide a link to information about install

Warn users if they don't have FURY installed.
And provide a link for installation.
@arokem

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

This better addresses issues such as #1718

@skoudoro
Copy link
Member

left a comment

Thank you for making it clearer! I will merge it after this small correction

'fury',
"You do not have FURY installed. Some visualization functions"
"might not work for you. For installation instructions, please visit: "
"https://fury.gl/")


if have_fury:

This comment has been minimized.

Copy link
@skoudoro

skoudoro Jul 16, 2019

Member

Can you update this variable have_fury to has_fury

This comment has been minimized.

Copy link
@arokem

arokem Jul 16, 2019

Author Member

Updated here and elsewhere to has_fury to be consistent with has_mpl below.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 17, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@17b68f0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1902   +/-   ##
=========================================
  Coverage          ?   85.41%           
=========================================
  Files             ?      119           
  Lines             ?    14309           
  Branches          ?     2249           
=========================================
  Hits              ?    12222           
  Misses            ?     1577           
  Partials          ?      510
Impacted Files Coverage Δ
dipy/viz/panel.py 83.09% <100%> (ø)
dipy/io/vtk.py 14.58% <100%> (ø)
dipy/viz/__init__.py 90% <100%> (ø)
dipy/viz/app.py 52.36% <100%> (ø)

@skoudoro skoudoro merged commit b838f96 into nipy:master Jul 17, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Thank you for this @arokem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.