Warn users if they don't have FURY installed #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And provide a link for installation.
|
This better addresses issues such as #1718 |
skoudoro
reviewed
Jul 16, 2019
dipy/viz/__init__.py
Outdated
| 'fury', | ||
| "You do not have FURY installed. Some visualization functions" | ||
| "might not work for you. For installation instructions, please visit: " | ||
| "https://fury.gl/") | ||
|
|
||
|
|
||
| if have_fury: |
There was a problem hiding this comment.
Can you update this variable have_fury to has_fury
There was a problem hiding this comment.
Updated here and elsewhere to has_fury to be consistent with has_mpl below.
Codecov Report
@@ Coverage Diff @@
## master #1902 +/- ##
=========================================
Coverage ? 85.41%
=========================================
Files ? 119
Lines ? 14309
Branches ? 2249
=========================================
Hits ? 12222
Misses ? 1577
Partials ? 510
|
|
Thank you for this @arokem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And provide a link to information about install