Increase affine consistency in dipy.tracking.life and dipy.stats.analysis #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
reviewed
Jul 31, 2019
dipy/tracking/life.py
Outdated
| @@ -261,7 +262,7 @@ def streamline_signal(self, streamline): | |||
| return sig_out | |||
|
|
|||
|
|
|||
| def voxel2streamline(streamline, transformed=False, affine=None, | |||
| def voxel2streamline(streamline, affine, transformed=False, | |||
There was a problem hiding this comment.
Here, you forgot to remove transformed=False parameter
Codecov Report
@@ Coverage Diff @@
## master #1943 +/- ##
=========================================
Coverage ? 84.63%
=========================================
Files ? 119
Lines ? 14701
Branches ? 2330
=========================================
Hits ? 12442
Misses ? 1712
Partials ? 547
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase consistency within Dipy and increase cautious behaviors when coding the affine is now required when it was previously optional.
Older/unused functions that had complex behavior related to spatial transform and trackvis file format were deleted to prevent confusion.
Docstring is now uniform when describing the affine.
Tests were executed and examples tested.