Fix vec2vec #334
Merged
Fix vec2vec #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to follow immediately :-)
This should fix this. No other side effects, as far as I could tell.
| rot_back = np.dot(Rp, v) | ||
| sign_reverser = np.sign((np.sign(rot_back) == np.sign(u)) - 0.5).squeeze() | ||
|
|
||
| # Multiply each line by it's reverser and reassmble the matrix: |
There was a problem hiding this comment.
# Multiply each line by its reverser and reassemble the matrix:
(sorry)
| # Everything's fine, up to a sign reversal: | ||
| rot_back = np.dot(Rp, v) | ||
| sign_reverser = np.sign((np.sign(rot_back) == np.sign(u)) - 0.5).squeeze() | ||
| # Multiply each line by it's reverser and reassmble the matrix: |
|
Thank you for the bug fix. Please fix this tiny typo and I will happily do the merge :) |
|
Done! On Sun, Mar 16, 2014 at 4:50 PM, Eleftherios Garyfallidis <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small bug in the calculation of rotation matrices.
The fix in the sims module follows, because test failures upon applying this fix indicated that this calculation was front-to-back. I think everything's alright now