New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed frozen windows executable issue #405

Merged
merged 4 commits into from Oct 7, 2014

Conversation

Projects
None yet
2 participants
@gabknight
Contributor

gabknight commented Jul 31, 2014

addressed issue #399

  • added freeze_support function call to reconst_*_parallel examples

I tried to make examples appear clear on the web page. What do you think?

@Garyfallidis Is this fixes the issue #399?

@gabknight gabknight changed the title from Frozen windows executable issue to fixed frozen windows executable issue Jul 31, 2014

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Aug 26, 2014

@gabknight here you only correct the parallel tutorials. But there are other tutorials that use parallel too. Do you see of a more generic way to protect ourselves from this problem?

@gabknight

This comment has been minimized.

Contributor

gabknight commented Aug 26, 2014

I was not aware of this issue, and didn't find a more generic way on the web. I don't have a windows system to reproduce the bug, which makes it hard to try-out pieces of code.

I removed parallel=True in reconst_csd.py and tracking_quick_start.py examples. Since there is the example reconst_csd_parallel.py, it should be parallel=False in reconst_csd.py. It would have been good to have parallel=True in tracking_quick_start.py. Nevertheless, users will notice the parallel arguments in peaks_from_model fct call.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Aug 26, 2014

Okay, cool. Let me think of this for a couple of days and then I will rather make a PR on top of yours or merge. Keep it up!

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Sep 30, 2014

Hi sorry for taking time to give you feedback about this PR. I think the best way forward is to add an if name == 'main' even in the quick start tutorial doc/examples/tracking_quick_start.py and call the freeze_support. It's better to work properly rather than being pretty. Make the change please and will merge. Thx!

@gabknight gabknight force-pushed the gabknight:frozen_windows_executable_issue branch from 4500a2e to 0b2b227 Oct 7, 2014

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 7, 2014

Thx Gab!

Garyfallidis added a commit that referenced this pull request Oct 7, 2014

Merge pull request #405 from gabknight/frozen_windows_executable_issue
fixed frozen windows executable issue

@Garyfallidis Garyfallidis merged commit cfce001 into nipy:master Oct 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment