BF: Trying to fix test failures. #46
Conversation
| @@ -185,7 +185,7 @@ def fit(self, data, mask=None, return_odf=False, gfa_thr=0.02, | |||
| global_max = max(global_max, odf.max()) | |||
| continue | |||
| pk, ind = local_maxima(odf, self.odf_edges) | |||
| pk, ind = _filter_peaks(pk, ind, | |||
| pk, ind = remove_similar_vertices(pk, ind, | |||
There was a problem hiding this comment.
These functions do things very differently, so I doubt a simple substitution will do the trick
There was a problem hiding this comment.
OK. What's a good way forward here?
I don't know this code well, so I am really asking where we should
pulling the thread, to unspool this ball of yarn.
On Tue, Jul 10, 2012 at 1:57 PM, Stefan van der Walt
reply@reply.github.com
wrote:
@@ -185,7 +185,7 @@ def fit(self, data, mask=None, return_odf=False, gfa_thr=0.02,
global_max = max(global_max, odf.max())
continue
pk, ind = local_maxima(odf, self.odf_edges)
pk, ind = _filter_peaks(pk, ind,pk, ind = remove_similar_vertices(pk, ind,These functions do things very differently, so I doubt a simple substitution will do the trick
Reply to this email directly or view it on GitHub:
https://github.com/nipy/dipy/pull/46/files#r1135467
|
I think @MrBago should give some pointers here. Yesterday, he said that he will have a look again on how _filter_peaks differs from remove_similar_peaks. |
Let's fix our test failures