BF: increased SCIPY version definition flag to 0.12 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,16 +12,16 @@ | |||
|
|
|||
| scipy_version = scipy.__version__ | |||
| scipy_version = StrictVersion(scipy_version.split('.dev')[0]) | |||
| minimize_version = StrictVersion('0.11') | |||
| minimize_version = StrictVersion('0.12') | |||
There was a problem hiding this comment.
How about:
from distutils.version import LooseVersion
SCIPY_LESS_0_12 = LooseVersion(scipy.__version__) < '0.12'
There was a problem hiding this comment.
What is the difference? Why Loose version?
There was a problem hiding this comment.
LooseVersion deals with 'dev' correctly so you don't have to do it - therefore making it easier to read IMO.
It also means you can use one line instead of several...
|
Okay thanx this was helpful info! Done! Let's see if the bots will sing tonight :) |
matthew-brett
added a commit
that referenced
this pull request
Nov 14, 2014
MRG: increased SCIPY version definition flag to 0.12 Change scipy dependency rules; should fix issue #461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @matthew-brett. I believe that this should fix issue #461