ENH: GradientTable now calculates qvalues

[demianw]

Added an attribute to calculate the q-value table from the b-value one when big and small delta are given to the gradient table.

[maurozucchelli]

Perfect! This is very useful also for me...

On Fri, Nov 21, 2014 at 10:14 AM, Demian Wassermann <
notifications@github.com> wrote:

Added an attribute to calculate the q-value table from the b-value one

when big and small delta are given to the gradient table.

You can merge this Pull Request by running

git pull https://github.com/demianw/dipy gradient_table_qval_calc

Or view, comment on, or merge it at:

#472
Commit Summary

• ENH: GradientTable now calculates qvals when big and small delta are
  provided

File Changes

• M dipy/core/gradients.py
  https://github.com/nipy/dipy/pull/472/files#diff-0 (8)
• M dipy/core/tests/test_gradients.py
  https://github.com/nipy/dipy/pull/472/files#diff-1 (16)

Patch Links:

• https://github.com/nipy/dipy/pull/472.patch
• https://github.com/nipy/dipy/pull/472.diff

—
Reply to this email directly or view it on GitHub
#472.

[arokem]

PEP8: spaces around operators

[demianw]

Yup, but PEP8 was not enforced at all on this file so I didn't know what's the project's policy on this

[arokem]

My policy is to comment when I see something that isn't PEP8. We're not
perfect, but we try...

On Fri, Nov 21, 2014 at 10:16 AM, Demian Wassermann <
notifications@github.com> wrote:

In dipy/core/tests/test_gradients.py:

@@ -164,7 +164,21 @@ def test_deltas():
npt.assert_equal(bt.big_delta, 5)
npt.assert_equal(bt.small_delta, 2)

+def test_qvalues():

• sq2 = np.sqrt(2)/2.
• bvals = 1500*np.ones(7)

Yup, but PEP8 was not enforced at all on this file so I didn't know what's
the project's policy on this

—
Reply to this email directly or view it on GitHub
https://github.com/nipy/dipy/pull/472/files#r20731123.

[matthew-brett]

Seems like a good PEP8 policy to me.

[arokem]

Thanks for adding this. The enthused endorsement by @maurozucchelli suggests that it will be immediately useful!

[arokem]

Great. I'll wait for Travis to finish cleanly here, and then merge this.