MRG: move conditional compiling to C #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do check for openmp with C preprocessor, and then use C variable checks to avoid using openmp constructs at build time.
Signal that code should use C-level conditionals rather than Cython-level conditionals by writing .h file instead of .pxi.
|
Eleftherios - does this preserve the Open MP things you need? Is there a good way of checking? It looks to me as if it does. |
Add the `src` include directory to allow all (bundlemin in fact) Cython files to be compiled into the source release tarball.
Try a few times to install travis wheels before giving up.
|
Yeah, it works. The tests look good too and the multithreading works in my machine. So, all good here. |
|
Matthew this says WIP here. Do you really need to add other commits or this is done? If this is done then it's already +1 from me. |
matthew-brett
changed the title
|
Thx! |
Garyfallidis
added a commit
that referenced
this pull request
Dec 29, 2014
MRG: move conditional compiling to C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using conditionals in the Cython file, but this means that we can't any
longer ship valid .c files with the release, and we would have to depend on
Cython at build time, even for releases.
Try moving the OpenMP defines into a C header so that the check for OpenMP
happens at C compile-time not Cython compile time.