New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Added missing contributor to developer list #619

Merged
merged 2 commits into from Apr 1, 2015

Conversation

Projects
None yet
3 participants
@jchoude
Contributor

jchoude commented Apr 1, 2015

Simply readd a missing developer from the contributor list. It seems to have been lost when updating the developers list during one of the last releases.

I also saw that there were other missing contributors (with low commit counts, as I do). @Garyfallidis said to wait before adding them.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

Had more thoughts on this. Let's add them all. The more the merrier! Thx man!

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

There should be 31 contributors in total.

@arokem

This comment has been minimized.

Member

arokem commented Apr 1, 2015

+1.

Maybe we should somehow consolidate and have this list only in one place? We have another list in AUTHOR

@jchoude

This comment has been minimized.

Contributor

jchoude commented Apr 1, 2015

Ok, I'll update this this afternoon with all names. However, I don't know if I'll easily be able to find the affiliation of everyone. I'll give it a go and let you know.

Also, as suggestion by @arokem, should we consolidate it only in one place, and if so, which one would be the best?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

I like that in this page we can give credit to the core devs who have contributed much more in the project. I would like here also to add links to their pages or even add information about their area of expertise. So, this is different from AUTHOR.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

No, sorry. There is no need to find the affiliations now. I will do that at a later stage. No rush on this.

@arokem

This comment has been minimized.

Member

arokem commented Apr 1, 2015

Sorry - this confuses me. I thought that you want to put all the
contributors on this page, not only core devs, as well as in the AUTHOR
file? I am worried that we'll need to constantly make sure that these are
in sync.

On Wed, Apr 1, 2015 at 10:12 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

I like that in this page we can give credit to the core devs who have
contributed much more in the project. I would like here also to add links
to their pages or even add information about their area of expertise. So,
this is different from AUTHOR.


Reply to this email directly or view it on GitHub
#619 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

@arokem this what we have right now http://nipy.org/dipy/developers.html Does that help de-confuse?

@arokem

This comment has been minimized.

Member

arokem commented Apr 1, 2015

Gotcha. Shouldn't be too hard to replicate this structure in the AUTHORS
file as well, right? Why do we need two different files with the same
information?

On Wed, Apr 1, 2015 at 10:17 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

http://nipy.org/dipy/developers.html


Reply to this email directly or view it on GitHub
#619 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

Because it is not the same information? The authors file is only the list of all authors. And the developers.rst gives more information about who the authors are and what they do. And should have more information in the future too. This file should be like the "Who are we" found in commercial websites. We could make it automatic in some way. But not sure if it worth the effort right now.

@arokem

This comment has been minimized.

Member

arokem commented Apr 1, 2015

OK.

On Wed, Apr 1, 2015 at 10:37 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Because it is not the same information? The authors file is only the list
of all authors. And the developers.rst gives more information about who the
authors are and what they do. And should have more information in the
future too. This file should be like the "Who are we" found in commercial
websites. We could make it automatic in some way. But not sure if it worth
the effort right now.


Reply to this email directly or view it on GitHub
#619 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

But hey point taken. It will be nice to have a script that updates developers.rst automatically.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

Let's think of a form first. Should have links to websites and short bios or summaries of interests for all the core devs at least? Anyway... let's think of it for a bit.

@arokem

This comment has been minimized.

Member

arokem commented Apr 1, 2015

Yeah - I think that it wouldn't be too hard to extend AUTHOR a bit, to be a
CSV table with some basic information about each contributor: email
address, but also affiliation, commit number, etc. Might make for useful
information about the project that we can use to tell people (e.g. funding
agencies...) about the project. One huge strength of the project which I
always emphasize when telling people about it, is that it's distributed
over many different labs/institutions/countries. We can demonstrate that
through a more careful collection of data. I've made an issue of it #620

On Wed, Apr 1, 2015 at 10:43 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Let's think of a form first. Should have links to websites and short bios
or summaries of interests for all the core devs at least? Anyway... let's
think of it for a bit.


Reply to this email directly or view it on GitHub
#619 (comment).

@jchoude

This comment has been minimized.

Contributor

jchoude commented Apr 1, 2015

Hey guys, just to let you know I added all missing contributors (at least, those that were listed with a git shortlog -ns).

I couldn't find any affilition for Andrew Lawrence, so if any of you know him, please let me know.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 1, 2015

Okay no worries. Let's update the website.

Garyfallidis added a commit that referenced this pull request Apr 1, 2015

Merge pull request #619 from jchoude/doc_add_missing_contrib
DOC: Added missing contributor to developer list

@Garyfallidis Garyfallidis merged commit 6d41ee6 into nipy:master Apr 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment