@sinkpoint's power map - refactored #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
force-pushed
the
sinkpoint-power_map
branch
3 times, most recently
from
a8b134c
to
bb6a4e3
Compare
- added sh_to_ap method to shm.py - added tests for sh_to_ap to test_shm.py
- added description of calculations
- changed some spelling and equation formatting mistakes
- changed param coeff_mtx to sh_coeffs - changed method description order - changed apostrophe character for Dell'Acqua
- changed formatting to conform to pep8
arokem
force-pushed
the
sinkpoint-power_map
branch
from
36866c9
to
e269414
Compare
|
OK - here's what I've come up with: I am now testing this with a very simplified set of coefficients, that are all equal to 1. In this case, it is easy to calculate what AP should be equal to: it's the log of the number of even coefficients (because in this case the 2l+1 factors cancel out). Then, the normalization factor has to be taken into account, which I do here by varying that between two different quantities. This seems like a better solution to me, because it tests the equation, rather than testing some other implementation of the same equation, on a specific test-set. I wouldn't mind having both in here, but I think this is sufficient. |
|
|
||
| def calculate_max_order(n_coeffs): | ||
| """ | ||
| Calculate the maximal harmonic order, given that you know the |
|
Good job! 👍 Many thanks to @sinkpoint, @arokem and @deflavio! |
Garyfallidis
added a commit
that referenced
this pull request
Oct 19, 2015
@sinkpoint's power map - refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - here are a few suggestions on top of @sinkpoint's implementation of the Dell'Acqua power map (#672). I think that this would be very useful to have, but I have proposed a few changes relative to @sinkpoint's previous implementation that simplify the code and potentially lead to (marginally) faster performance. See here for a diff relative to #672 (ignore the top of this diff in
denspeed- that has to do with the fact that #672 needs a rebase):https://github.com/sinkpoint/dipy/pull/1/files