RF: Move the peaks module from dipy.reconst to dipy.directions. #770
Conversation
|
Shouldn't this get moved to |
|
Clearly this by itself is no good :-) |
arokem
changed the title
|
How does this look @MrBago ? |
|
Can you add a deprecation warning and import the new module in the old one for compatibility with old stuff? |
…ning. To be removed completely on the next cycle.
|
How's that @samuelstjean ? |
|
@MrBago can you merge this PR if you think it is okay? We are in release mode right now and we would appreciate some quick feedback so we can move on. Thx in advance. |
|
This looks good to me. My only question is about the DeprecationWarning, these are silenced by default so most people will not see them. Do we want something stronger? I feel like this question has come up before so if we settled on decision, I'm sorry for raising it again. |
|
I agree that this is an important discussion and I am not sure we had a final decision on this. But because this is a generic design issue and not related with this PR I would suggest to move on with the release and then open an issue or a discussion in gitter to figure out the best warning strategy. Sounds good? |
RF: Move the peaks module from dipy.reconst to dipy.directions.
|
K, I'm merging this. I brought this up partially because we're already using UserWarnings for this kind of thing in some places, /home/bagrata/projects/dipy/dipy/align/aniso2iso.py. |
|
Good reminder. Write an issue please so we can keep track of that. |
|
We should clearly resolve this problem by 0.11 release. |
Addresses #517